piyushghai commented on a change in pull request #12955: [MXNET-1159]Added unit
tests for making Resource Scope work in Java
URL: https://github.com/apache/incubator-mxnet/pull/12955#discussion_r227867686
##########
File path: scala-package/pom.xml
##########
@@ -190,8 +190,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.3</version>
<configuration>
- <source>1.6</source>
- <target>1.6</target>
+ <source>1.8</source>
Review comment:
I think it's just for Maven compilation.
> > It's in the PR description :
> > " Made Maven compiler plugin to use 1.8 in order to use Java Lambda
expressions and try-with-resources in Java"
>
> But does this mean we lose support for Java7 users? Or this is just a
definition for Maven
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
