lanking520 commented on a change in pull request #12955: [MXNET-1159]Added unit
tests for making Resource Scope work in Java
URL: https://github.com/apache/incubator-mxnet/pull/12955#discussion_r227870774
##########
File path: scala-package/pom.xml
##########
@@ -190,8 +190,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.3</version>
<configuration>
- <source>1.6</source>
- <target>1.6</target>
+ <source>1.8</source>
Review comment:
After checking the
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html
website here, this would lead to some problems for users using Java7. Here is
what I have tried locally (with my JDK 1.8):
```
8c85904324fa:incubator-mxnet qingla$ javac -source 1.9
javac: invalid source release: 1.9
Usage: javac <options> <source files>
use -help for a list of possible options
8c85904324fa:incubator-mxnet qingla$ javac -source 1.8
javac: no source files
Usage: javac <options> <source files>
use -help for a list of possible options
8c85904324fa:incubator-mxnet qingla$ javac -source 1.7
javac: no source files
Usage: javac <options> <source files>
use -help for a list of possible options
```
Since we have not decided to fully abandon 1.7 users, this change may risk
their usages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
