nswamy closed pull request #12965: Bumping down minimum java support from 8 to 7
URL: https://github.com/apache/incubator-mxnet/pull/12965
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/scala-package/core/src/test/java/org/apache/mxnet/javaapi/ResourceScopeTestSuite.java
b/scala-package/core/src/test/java/org/apache/mxnet/javaapi/ResourceScopeTestSuite.java
index f570ba927fa..1c246d870e2 100644
---
a/scala-package/core/src/test/java/org/apache/mxnet/javaapi/ResourceScopeTestSuite.java
+++
b/scala-package/core/src/test/java/org/apache/mxnet/javaapi/ResourceScopeTestSuite.java
@@ -73,7 +73,9 @@ public void testObjectReleaseFromList() {
}
assertEquals(list.size() , 10);
- list.forEach(n -> assertTrue(n.verifyIsDisposed()));
+ for (TestNDArray item : list) {
+ assertTrue(item.verifyIsDisposed());
+ }
}
@Test
@@ -87,7 +89,9 @@ public void testObjectReleaseFromMap() {
}
assertEquals(stringToNDArrayMap.size(), 10);
- stringToNDArrayMap.forEach((key, value) ->
assertTrue(value.verifyIsDisposed()));
+ for (Map.Entry<String, TestNDArray> entry :
stringToNDArrayMap.entrySet()) {
+ assertTrue(entry.getValue().verifyIsDisposed());
+ }
Map<TestNDArray, String> ndArrayToStringMap = new HashMap<>();
@@ -98,7 +102,9 @@ public void testObjectReleaseFromMap() {
}
assertEquals(ndArrayToStringMap.size(), 10);
- ndArrayToStringMap.forEach((key, value) ->
assertTrue(key.verifyIsDisposed()));
+ for (Map.Entry<TestNDArray, String> entry :
ndArrayToStringMap.entrySet()) {
+ assertTrue(entry.getKey().verifyIsDisposed());
+ }
}
}
diff --git a/scala-package/pom.xml b/scala-package/pom.xml
index eb3f6f0b335..9f7a498ee9b 100644
--- a/scala-package/pom.xml
+++ b/scala-package/pom.xml
@@ -190,8 +190,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.3</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>1.7</source>
+ <target>1.7</target>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
