szha commented on a change in pull request #12804: CudnnFind() usage
improvements
URL: https://github.com/apache/incubator-mxnet/pull/12804#discussion_r227972269
##########
File path: src/storage/pooled_storage_manager.h
##########
@@ -57,6 +57,7 @@ class GPUPooledStorageManager final : public StorageManager {
GPUPooledStorageManager() {
reserve_ = dmlc::GetEnv("MXNET_GPU_MEM_POOL_RESERVE", 5);
page_size_ = dmlc::GetEnv("MXNET_GPU_MEM_POOL_PAGE_SIZE", 4096);
+ large_alloc_round_size_ =
dmlc::GetEnv("MXNET_GPU_MEM_LARGE_ALLOC_ROUND_SIZE", 2 * 1024 * 1024);
Review comment:
I developed another rounding memory manager that uses a combination of
exponential rounding size and linear rounding size and has shown good results.
If adding rounding to GPU is desired by default, I think we can combine them
into a single memory manager that offer these knobs.
let's address the memory pool change in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
