blac2kite commented on a change in pull request #12804: CudnnFind() usage
improvements
URL: https://github.com/apache/incubator-mxnet/pull/12804#discussion_r227998830
##########
File path: src/operator/nn/cudnn/cudnn_algoreg-inl.h
##########
@@ -75,7 +81,7 @@ class CuDNNAlgoReg {
bool add_to_weight,
CuDNNAlgo<cudnnConvolutionFwdAlgo_t> *fwd,
CuDNNAlgo<cudnnConvolutionBwdDataAlgo_t> *bwd,
- CuDNNAlgo<cudnnConvolutionBwdFilterAlgo_t> *flt) {
+ CuDNNAlgo<cudnnConvolutionBwdFilterAlgo_t> *flt, AlgoSetter_t
algo_setter) {
Review comment:
Minor: Other parameters are on their own lines. Maybe algo_setter can go in
its own line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
