lanking520 commented on issue #12489: [WIP][MXNET-918] Random api URL: https://github.com/apache/incubator-mxnet/pull/12489#issuecomment-433469267 @mdespriee thanks for your effort to refactor the code. The issue shown above is the mismatch on the parameter. It can be caused by `function name` do not have this parameter, or you put a param in the wrong type. I would recommend you to split the refactoring portion and Random generation portion into two PRs. The good thing: 1. you can focus on each of them and make the refactoring and Random part even better. 2. Reduce the change on your code, it's easier for you to find where the problem is and easy for us to help you find where you can make a mistake. I know this may introduce more work to you but I think this could be the best solution.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
