samskalicky commented on a change in pull request #12904: support upper
triangular matrices in linalg
URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r229844162
##########
File path: src/operator/tensor/la_op.h
##########
@@ -93,6 +104,9 @@ struct LaTriangMatrixMultParam : public
dmlc::Parameter<LaTriangMatrixMultParam>
DMLC_DECLARE_FIELD(rightside)
.set_default(false)
.describe("Multiply triangular matrix from the right to non-triangular
one.");
+ DMLC_DECLARE_FIELD(lower)
+ .set_default(true)
+ .describe("Triangular matrix is lower triangular.");
Review comment:
same as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
