larroy commented on a change in pull request #13046: [MXNET-1155] Add scala
packageTest utility
URL: https://github.com/apache/incubator-mxnet/pull/13046#discussion_r229855913
##########
File path: Makefile
##########
@@ -602,6 +602,14 @@ scalaclean:
(cd $(ROOTDIR)/scala-package; \
mvn clean -P$(SCALA_PKG_PROFILE),$(SCALA_VERSION_PROFILE))
+scalatestcompile:
+ (cd $(ROOTDIR)/scala-package; \
Review comment:
Why the parenthesis? Also what if cd fails?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
