pengzhao-intel commented on a change in pull request #13088: make ROIAlign support position-sensitive pooling URL: https://github.com/apache/incubator-mxnet/pull/13088#discussion_r230542141
########## File path: src/operator/contrib/roi_align.cc ########## @@ -213,14 +214,21 @@ void ROIAlignForward( num_threads(engine::OpenMP::Get()->GetRecommendedOMPThreadCount()) Review comment: From our local test, the better performance will be gained if we move this OMP into `n_rois` loop, L160. Could you help change this and test the performance with your cases? Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
