nswamy commented on a change in pull request #12852: [MXNET-879] ONNX export:
Logical operators
URL: https://github.com/apache/incubator-mxnet/pull/12852#discussion_r230571840
##########
File path: tests/python-pytest/onnx/export/mxnet_export_test.py
##########
@@ -238,6 +251,70 @@ def test_square():
npt.assert_almost_equal(result, numpy_op)
+@with_seed()
+def test_logical_and():
Review comment:
for these simple operators, instead of repeating test code for each of them,
can you create a map[operator] = (input, output) and run all operators tests in
one test method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
