nswamy commented on a change in pull request #12812: [MXNET-886] ONNX export:
HardSigmoid, Less, Greater, Equal
URL: https://github.com/apache/incubator-mxnet/pull/12812#discussion_r230597795
##########
File path: tests/python-pytest/onnx/export/mxnet_export_test.py
##########
@@ -238,6 +238,63 @@ def test_square():
npt.assert_almost_equal(result, numpy_op)
+@with_seed()
+def test_greater():
Review comment:
I am seeing that a lot of repetitions in the test code. Could you please
modularize the test code? happy to discuss offline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
