apeforest commented on a change in pull request #12749: [MXNET-1029] Feature
request: randint operator
URL: https://github.com/apache/incubator-mxnet/pull/12749#discussion_r230847429
##########
File path: src/operator/random/sample_op.h
##########
@@ -249,6 +254,30 @@ struct SampleGenNegBinomialParam : public
dmlc::Parameter<SampleGenNegBinomialPa
}
};
+struct SampleRandIntParam : public dmlc::Parameter<SampleRandIntParam>,
+ RandIntParam, SampleOpParam {
+ DMLC_DECLARE_PARAMETER(SampleRandIntParam) {
+ DMLC_DECLARE_FIELD(low).set_default(0)
+ .describe("Lower bound of the distribution.");
+ DMLC_DECLARE_FIELD(high).set_default(1)
Review comment:
These low and high defaults may not be appropriate for this operator. What
do you expect them to get out of these?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
