lebeg commented on a change in pull request #13077: Add --no-cache option to
build.py when building containers
URL: https://github.com/apache/incubator-mxnet/pull/13077#discussion_r231484860
##########
File path: ci/build.py
##########
@@ -112,7 +112,7 @@ def get_docker_binary(use_nvidia_docker: bool) -> str:
return "nvidia-docker" if use_nvidia_docker else "docker"
-def build_docker(platform: str, docker_binary: str, registry: str,
num_retries: int, use_cache: bool) -> str:
+def build_docker(platform: str, docker_binary: str, registry: str,
num_retries: int, use_cache: bool, no_cache: bool) -> str:
Review comment:
Is `no_cache` the same as `!use_cache`? Otherwise the naming is really
confusing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
