andrewfayres commented on a change in pull request #13191: [MXNET-1185] Support large array in several operators URL: https://github.com/apache/incubator-mxnet/pull/13191#discussion_r233678826
########## File path: scala-package/native/src/main/native/org_apache_mxnet_native_c_api.cc ########## @@ -1549,25 +1549,25 @@ JNIEXPORT jint JNICALL Java_org_apache_mxnet_LibInfo_mxSymbolInferShape mx_uint inShapeSize; const mx_uint *inShapeNdim; - const mx_uint **inShapeData; + const dim_t **inShapeData; mx_uint outShapeSize; const mx_uint *outShapeNdim; - const mx_uint **outShapeData; + const dim_t **outShapeData; mx_uint auxShapeSize; const mx_uint *auxShapeNdim; - const mx_uint **auxShapeData; + const dim_t **auxShapeData; int complete; jint *argIndPtr = env->GetIntArrayElements(jargIndPtr, NULL); - jint *argShapeData = env->GetIntArrayElements(jargShapeData, NULL); + jlong *argShapeData = env->GetLongArrayElements(jargShapeData, NULL); Review comment: jargShapeData is a jIntArray. Needs to be updated to a jlongArray I believe. Since this is coming from the constructor it probably needs to be changed in the Scala code too. I'll try and figure out where and add suggestions to this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
