apeforest commented on a change in pull request #13191: [MXNET-1185] Support
large array in several operators
URL: https://github.com/apache/incubator-mxnet/pull/13191#discussion_r233716563
##########
File path:
scala-package/native/src/main/native/org_apache_mxnet_native_c_api.cc
##########
@@ -1519,14 +1519,14 @@ JNIEXPORT jint JNICALL
Java_org_apache_mxnet_LibInfo_mxSymbolCreateFromFile
int FillSymbolInferShape
(JNIEnv *env, jmethodID listAppend, jobject joutData,
- mx_uint shapeSize, const mx_uint *shapeNdim, const mx_uint **shapeData) {
+ mx_uint shapeSize, const mx_uint *shapeNdim, const dim_t **shapeData) {
for (size_t i = 0; i < shapeSize; ++i) {
jintArray jshape = env->NewIntArray(shapeNdim[i]);
Review comment:
@andrewfayres Thanks for your review. I have updated code based on your
suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
