junrushao1994 opened a new pull request #13283: [MXNET-1215] Allow dynamic 
shape exists in imperative mode
URL: https://github.com/apache/incubator-mxnet/pull/13283
 
 
   ## Description ##
   It is the PR I took over from @zheng-da at #12400 . All credits go to Da 
Zheng.
   
   This PR releases the constraint on NDArrays that shape used to be 
pre-determined. For unittesting, this PR introduces an operator called 
`BooleanMask` in contrib, which is a practical use case that actually produces 
dynamic shape.
   
   This is an initial step for the roadmap #12732.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Introducing new methods in NDArray allowing delayed assignment of 
their shapes.
   - [x] Introducing boolean mask operator, which we believe will be useful in 
the future.
   - [ ] Add unit test.
   
   ## Comments ##
   No comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to