apeforest commented on a change in pull request #13276: enabling test_dropout
after fixing flaky issue
URL: https://github.com/apache/incubator-mxnet/pull/13276#discussion_r233958135
##########
File path: src/operator/nn/dropout-inl.h
##########
@@ -92,7 +92,7 @@ class DropoutOp {
const int my_amount = std::min(my_offset + avg_amount, n) - my_offset;
if (my_amount > 0) {
VSLStreamStatePtr stream;
- vslNewStream(&stream, VSL_BRNG_MCG31, seed + my_offset);
+ vslNewStream(&stream, VSL_BRNG_MCG31, seed);
Review comment:
Why remove the my_offset here while leaving them in the vslSkipAheadStream
and viRngBernoulli functions? What's the rationale behind? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
