ZhennanQin commented on a change in pull request #13283: [MXNET-1215] Allow dynamic shape exists in imperative mode URL: https://github.com/apache/incubator-mxnet/pull/13283#discussion_r234065150
########## File path: src/operator/contrib/boolean_mask-inl.h ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +/*! + * Copyright (c) 2018 by Contributors + * \file boolean_mask-inl.h +*/ + +#ifndef MXNET_OPERATOR_CONTRIB_BOOLEAN_MASK_INL_H_ +#define MXNET_OPERATOR_CONTRIB_BOOLEAN_MASK_INL_H_ + +#include <dmlc/logging.h> +#include <dmlc/parameter.h> +#include <mxnet/operator.h> +#include <mxnet/ndarray.h> +#include <map> +#include <vector> +#include <string> +#include <utility> +#include "../operator_common.h" +#include "../mxnet_op.h" +#include "../mshadow_op.h" + +namespace mxnet { +namespace op { + +struct BooleanMaskParam : public dmlc::Parameter<BooleanMaskParam> { + int axis; + DMLC_DECLARE_PARAMETER(BooleanMaskParam) { + DMLC_DECLARE_FIELD(axis).set_default(0) + .describe("An integer that represents the axis in NDArray to mask from."); + } +}; + +template <typename xpu> Review comment: This is a pure CPU specific implementation, this template keyword will mislead other developer this could be used for GPU as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
