apeforest commented on a change in pull request #12884: adding unittest for
MKLDNN Softmax operator
URL: https://github.com/apache/incubator-mxnet/pull/12884#discussion_r234535322
##########
File path: tests/cpp/operator/mkldnn_operator_test.cc
##########
@@ -866,6 +925,12 @@ TEST(IMPERATIVE, LRNOp) {
TestOpEx(forward_attrs, backwards_attrs);
}
+TEST(IMPERATIVE, SoftmaxOp) {
+ OpAttrs forward_attrs = GetSoftmaxOp();
+ OpAttrs backwards_attrs;
Review comment:
Why not have a function GetSoftmaxBackwardsOp() like in line
https://github.com/apache/incubator-mxnet/pull/12884/files#diff-472f3cc48fa2159cf280bf25b15417eaR936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
