anirudh2290 commented on a change in pull request #12884: adding unittest for
MKLDNN Softmax operator
URL: https://github.com/apache/incubator-mxnet/pull/12884#discussion_r234849590
##########
File path: tests/cpp/operator/mkldnn_operator_test.cc
##########
@@ -523,8 +575,8 @@ void TestOpEx(const OpAttrs &forward_attrs, const OpAttrs
&backwards_attrs) {
for (int i1 = 0; i1 < in_arrs.size(); i1++) {
auto in_arr = in_arrs[i1];
- // TODO(alex): (MXNET-845) Remove when MKLDNN supports other dims
- if (in_arr.arr.shape().ndim() != 4)
+ if (forward_attrs.accept_dims.find(in_arr.arr.shape().ndim()) ==
Review comment:
dont we want all tests which use TestOpEx to atleast provide one element in
accept_dims. Other option is to have a default ndim like 4 inside accept_dims.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
