apeforest commented on a change in pull request #13297: [MKLDNN]Add quantized
concat
URL: https://github.com/apache/incubator-mxnet/pull/13297#discussion_r235216489
##########
File path: src/operator/quantization/quantization_utils.h
##########
@@ -31,6 +31,8 @@
namespace mxnet {
namespace op {
+static const size_t uint8_range = 255;
Review comment:
Sorry for the confusion, MXNet follows the Google C++ Style Guide for const
names. Please follow this:
https://google.github.io/styleguide/cppguide.html#Constant_Names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
