mseth10 commented on a change in pull request #13328: adding test for softmax
operator for large negative inputs
URL: https://github.com/apache/incubator-mxnet/pull/13328#discussion_r235239845
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -383,6 +383,17 @@ def check_fullyconnected_training(stype):
for stype in stypes:
check_fullyconnected_training(stype)
+def test_softmax_with_large_negative_inputs():
+ input_data = mx.nd.array([[[[-1e30,-1e30]]]])
Review comment:
Added more corner cases: extremely large positive and negative inputs
covered (also checked for max and min values of float32 inputs). Please suggest
if you think there are more corner cases that should be added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
