TaoLv commented on a change in pull request #13260: Support full convention in quantized pooling URL: https://github.com/apache/incubator-mxnet/pull/13260#discussion_r235268826
########## File path: tests/python/quantization/test_quantization.py ########## @@ -214,7 +214,7 @@ def check_quantized_conv(data_shape, kernel, num_filter, pad, stride, no_bias, q @with_seed() def test_quantized_pooling(): - def check_quantized_pooling(data_shape, kernel, pool_type, pad, stride, global_pool, qdtype): + def check_quantized_pooling(data_shape, kernel, pool_type, pad, stride, global_pool, qdtype, convention): Review comment: The default convention for mxnet pooling is "valid". https://github.com/apache/incubator-mxnet/blob/master/src/operator/nn/pooling-inl.h#L74 I will set the default value for argument "convention" to "valid" here and revert the change for L264-L267. So the behavior of these 4 test cases will be as before. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
