apeforest commented on a change in pull request #13000: fix quantize_graph pass
error when there're multiple outputs from a single node
URL: https://github.com/apache/incubator-mxnet/pull/13000#discussion_r235527481
##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -156,29 +158,54 @@ Graph QuantizeGraph(Graph &&src) {
new_node->inputs.emplace_back(mirror_entry);
} else if (!NeedQuantize(e.node, excluded_nodes) &&
(mirror_node->op() == nullptr ||
- mirror_node->op()->name != "_contrib_quantize")) {
+ mirror_node->op()->name != "_contrib_quantize") &&
Review comment:
Using `entry` is fine with me as long as you are not only comparing the op
name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
