stu1130 commented on a change in pull request #13062: Add header files required
by horovod
URL: https://github.com/apache/incubator-mxnet/pull/13062#discussion_r235867467
##########
File path: python/mxnet/libinfo.py
##########
@@ -77,5 +77,36 @@ def find_lib_path():
return lib_path
+def find_include_path():
+ """Find MXNet dynamic library files.
+
+ Returns
+ -------
+ incl_path : string
+ Path to the header files.
+ """
+ incl_from_env = os.environ.get('MXNET_INCLUDE_PATH')
+ if incl_from_env:
+ if os.path.isfile(incl_from_env):
+ if not os.path.isabs(incl_from_env):
+ logging.warning("MXNET_INCLUDE_PATH should be an absolute
path, instead of: %s",
+ incl_from_env)
+ else:
+ if os.name == 'nt':
+ os.environ['PATH'] = os.environ['PATH'] + ';' +
os.path.dirname(incl_from_env)
+ return [incl_from_env]
+ else:
+ logging.warning("MXNET_INCLUDE_PATH '%s' doesn't exist",
incl_from_env)
+
+ curr_path = os.path.dirname(os.path.abspath(os.path.expanduser(__file__)))
+ incl_path = os.path.join(curr_path, '../../include/')
+ if len(incl_path) == 0:
Review comment:
even if the curr_path = '' the len(incl_path) could never zero?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
