lebeg commented on a change in pull request #12591: USE_MKLDNN=1 is default in
make build (mkldnn must be explicitly turned off)
URL: https://github.com/apache/incubator-mxnet/pull/12591#discussion_r235880592
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -170,6 +171,7 @@ build_armv7() {
-DCMAKE_BUILD_TYPE=Release \
-DUSE_MKL_IF_AVAILABLE=OFF \
-DUSE_LAPACK=OFF \
+ -DUSE_MKLDNN=0FF \
Review comment:
You have changed the default behaviour for make builds, but as far as I know
for cmake it was
[`ON`](https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L23)
by default (is available). Why do we want to switch it explicitly `OFF`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
