KellenSunderland commented on issue #13389: how to carry out unit test on essential classes URL: https://github.com/apache/incubator-mxnet/issues/13389#issuecomment-441387974 Agree with Marco's points, but just wanted to mention that we're certainly open to adding C++ tests for classes like the engine. I see a number of advantages for having C++ tests: * First cost and execution time is substantially less for C++ tests. * Some of the platforms we'd like to support don't have full python installations, and some customers choose not to install python in their build systems, so having some tests that work without python is nice. * Some behaviours of the engine are abstracted and non-testable from the Python level. This leads to a lot of non-deterministic behaviour at the Python level that could be tested deterministically at the C++ level. So the summary for me is that we have reasonably good critical class coverage from Python tests (which we actually measure), but adding some key C++ tests especially for these classes would be beneficial.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
