zhreshold commented on issue #13318: Improving multi-processing reliability for 
gluon DataLoader
URL: https://github.com/apache/incubator-mxnet/pull/13318#issuecomment-441524865
 
 
   This PR is good to merge. Before merging, I need to add a note that for 
statement (2), built-in structures are thread-safe for single operation, so it 
was actually good.
   
   However, introducing lock here will actually protect if it goes to separate 
operations in the future and adding peace of mind. So I think the lock is good 
here. 
   
   Thanks @YutingZhang for contribution. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to