KellenSunderland commented on a change in pull request #13297: [MKLDNN]Add
quantized concat
URL: https://github.com/apache/incubator-mxnet/pull/13297#discussion_r236362027
##########
File path: src/operator/quantization/quantization_utils.h
##########
@@ -31,6 +31,8 @@
namespace mxnet {
namespace op {
+static const size_t uint8_range = 255;
Review comment:
Are static const all upper case in Google Style? I'd think this would be
kuint8Range no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
