piyushghai commented on a change in pull request #13358: Java demo file-path fix
URL: https://github.com/apache/incubator-mxnet/pull/13358#discussion_r236485895
##########
File path: scala-package/mxnet-demo/java-demo/pom.xml
##########
@@ -8,18 +8,55 @@
<version>1.0-SNAPSHOT</version>
<name>MXNet Java Demo</name>
+ <repositories>
+ <repository>
+ <id>Apache Snapshot</id>
+ <url>https://repository.apache.org/content/groups/snapshots</url>
+ </repository>
+ </repositories>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ </properties>
+
<dependencies>
<dependency>
<groupId>org.apache.mxnet</groupId>
<artifactId>mxnet-full_${mxnet.scalaprofile}-${mxnet.profile}</artifactId>
<version>${mxnet.version}</version>
- <scope>system</scope>
-
<systemPath>${project.basedir}/mxnet-full_${mxnet.scalaprofile}-${mxnet.profile}-${mxnet.version}.jar</systemPath>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.4</version>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
Review comment:
this will do the same job as the plugin you are specifying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
