anirudhacharya commented on a change in pull request #13226: [MXNet-1211]
Factor and "Like" modes in BilinearResize2D operator
URL: https://github.com/apache/incubator-mxnet/pull/13226#discussion_r236742208
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -6527,12 +6527,64 @@ def check_bilinear_resize_op(shape, height, width):
x = mx.nd.random.uniform(shape=shape)
y = mx.nd.contrib.BilinearResize2D(x, height=height, width=width)
assert_almost_equal(y.asnumpy(), py_bilinear_resize(x.asnumpy(),
height, width))
+ def check_bilinear_resize_modes_op(shape, height_factor=None,
width_factor=None, shape_1=None, mode=None):
+ x = mx.nd.random.uniform(shape=shape)
Review comment:
unit tests for operators should cover forward pass and backward pass. See
here - https://mxnet.incubator.apache.org/faq/add_op_in_backend.html#unit-test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
