anirudh2290 commented on a change in pull request #13311: [MXNET-703] Minor
refactor of TensorRT code
URL: https://github.com/apache/incubator-mxnet/pull/13311#discussion_r237658649
##########
File path: src/executor/onnx_to_tensorrt.cc
##########
@@ -100,8 +100,8 @@ nvinfer1::ICudaEngine* onnxToTrtCtx(
}
if ( !trt_parser->parse(onnx_model.c_str(), onnx_model.size()) ) {
- int nerror = trt_parser->getNbErrors();
- for ( int i=0; i < nerror; ++i ) {
+ size_t nerror = trt_parser->getNbErrors();
+ for ( size_t i=0; i < nerror; ++i ) {
Review comment:
nit: can we make this consistent to other mxnet code: ```for (size_t i = 0;
i < nerror; ++i)```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
