apeforest commented on a change in pull request #13197: build mkldnn as static
lib on mac/linux
URL: https://github.com/apache/incubator-mxnet/pull/13197#discussion_r238005680
##########
File path: Makefile
##########
@@ -131,8 +131,13 @@ ifeq ($(USE_MKLDNN), 1)
CFLAGS += -I$(MKLROOT)/include
LDFLAGS += -L$(MKLROOT)/lib
endif
- CFLAGS += -I$(MKLDNNROOT)/include
- LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}'
+
+ ifneq ($(UNAME_S), Windows)
+ LIB_DEP += $(MKLDNNROOT)/lib/libmkldnn.a
+ else
+ CFLAGS += -I$(MKLDNNROOT)/include
+ LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}'
+ endif
Review comment:
Why isn't this aligned with L126 then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
