yzhliu commented on a change in pull request #13498: Fix flaky test
test_random:test_randint_generator
URL: https://github.com/apache/incubator-mxnet/pull/13498#discussion_r238043236
##########
File path: tests/python/unittest/test_random.py
##########
@@ -871,14 +871,15 @@ def test_randint_generator():
buckets = np.array(buckets, dtype=dtype).tolist()
probs = [(buckets[i][1] - buckets[i][0]) / float(scale) for i in
range(5)]
generator_mx = lambda x: mx.nd.random.randint(low, high, shape=x,
ctx=ctx, dtype=dtype).asnumpy()
- verify_generator(generator=generator_mx, buckets=buckets,
probs=probs)
+ verify_generator(generator=generator_mx, buckets=buckets,
probs=probs, alpha=0.01)
Review comment:
suggest to try if we can increase alpha, I also feel nrepeat=5 is a little
too small that might cause flasky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
