sandeep-krishnamurthy commented on a change in pull request #13197: build
mkldnn as static lib on mac/linux
URL: https://github.com/apache/incubator-mxnet/pull/13197#discussion_r238054876
##########
File path: Makefile
##########
@@ -131,8 +131,13 @@ ifeq ($(USE_MKLDNN), 1)
CFLAGS += -I$(MKLROOT)/include
LDFLAGS += -L$(MKLROOT)/lib
endif
- CFLAGS += -I$(MKLDNNROOT)/include
- LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}'
+
+ ifneq ($(UNAME_S), Windows)
Review comment:
Should we add a reason here, on why on Windows, it is dynamically linked for
future maintenance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
