TaoLv commented on a change in pull request #13197: build mkldnn as static lib
on mac/linux
URL: https://github.com/apache/incubator-mxnet/pull/13197#discussion_r238067167
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -441,7 +440,4 @@ def backward(self, req, out_grad, in_data, out_data,
in_grad, aux):
custom = mx.symbol.Custom(name='custom', data=conv, op_type='custom')
exec1 = custom.bind(mx.cpu(), args={'data': mx.nd.ones([10,3,96,96]),
'conv_weight': mx.nd.ones([8,3,5,5])})
exec1.forward()[0].wait_to_read()
-
-
-if __name__ == '__main__':
- install.test_mkldnn_install()
Review comment:
Need make sure about the purpose of a test case before removing it. If this
case is just for verifying whether MKL-DNN so is correctly linked, I'm OK with
removing it. Otherwise, need replace it with something else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
