mseth10 commented on a change in pull request #13498: Fix flaky test
test_random:test_randint_generator
URL: https://github.com/apache/incubator-mxnet/pull/13498#discussion_r238493998
##########
File path: python/mxnet/test_utils.py
##########
@@ -1920,7 +1919,7 @@ def chi_square_check(generator, buckets, probs,
nsamples=1000000):
_, p = ss.chisquare(f_obs=obs_freq, f_exp=expected_freq)
return p, obs_freq, expected_freq
-def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5,
success_rate=0.15):
+def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5,
success_rate=0.25, alpha=0.05):
Review comment:
How are we deciding on the success rate to be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
