ChaiBapchya commented on a change in pull request #13498: Fix flaky test
test_random:test_randint_generator
URL: https://github.com/apache/incubator-mxnet/pull/13498#discussion_r238776724
##########
File path: python/mxnet/test_utils.py
##########
@@ -1920,7 +1919,7 @@ def chi_square_check(generator, buckets, probs,
nsamples=1000000):
_, p = ss.chisquare(f_obs=obs_freq, f_exp=expected_freq)
return p, obs_freq, expected_freq
-def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5,
success_rate=0.15):
+def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5,
success_rate=0.25, alpha=0.05):
Review comment:
Success rate as defined in the function definition comment to be default to
25%
However, in the parameters it was wrongly set to 0.15. So I corrected it to
0.25
As far as alpha goes, same it is defined in the comment to be default to 0.05
Usage of success rate:
```success_num < nrepeat * success_rate```
To ensure the p value is above the min threshold (for e.g. 25% of all
attempts)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
