zachgk commented on a change in pull request #13450: [WIP][MXNET-862] Basic
maven jenkins pipeline
URL: https://github.com/apache/incubator-mxnet/pull/13450#discussion_r238787408
##########
File path: Makefile
##########
@@ -650,11 +662,20 @@ scalarelease-perform:
scaladeploy:
(cd $(ROOTDIR)/scala-package; \
- mvn deploy
-Papache-release,$(SCALA_PKG_PROFILE),$(SCALA_VERSION_PROFILE)
\-DskipTests=true -Dcxx="$(CXX)" \
+ mvn deploy $(MAVEN_ARGS)
-Papache-release,$(SCALA_PKG_PROFILE),$(SCALA_VERSION_PROFILE)
\-DskipTests=true -Dcxx="$(CXX)" \
-Dbuild.platform="$(SCALA_PKG_PROFILE)" \
-Dcflags="$(CFLAGS)" -Dldflags="$(LDFLAGS)" \
-Dlddeps="$(LIB_DEP) $(ROOTDIR)/lib/libmxnet.a")
+scaladeploylocal:
+ (cd $(ROOTDIR)/scala-package; \
+ mvn deploy $(MAVEN_ARGS)
-Papache-release,$(SCALA_PKG_PROFILE),$(SCALA_VERSION_PROFILE)
\-DskipTests=true -Dcxx="$(CXX)" \
Review comment:
We are skipping those tests because we run the tests separately with
scalaunittest/scalaintegrationtest before calling deploy and there is no reason
to repeat tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
