marcoabreu commented on a change in pull request #13450: [WIP][MXNET-862] Basic
maven jenkins pipeline
URL: https://github.com/apache/incubator-mxnet/pull/13450#discussion_r238839544
##########
File path: ci/Jenkinsfile_utils.groovy
##########
@@ -18,18 +18,23 @@
// under the License.
// initialize source codes
-def init_git() {
+// Clean - 0: None, 1: xdf, 2: xdff
+def init_git(clean=2) {
deleteDir()
retry(5) {
try {
// Make sure wait long enough for api.github.com request quota.
Important: Don't increase the amount of
// retries as this will increase the amount of requests and worsen the
throttling
timeout(time: 15, unit: 'MINUTES') {
checkout scm
- sh 'git clean -xdff'
+ if(clean == 1)
+ clean = 'git clean -xdf'
+ else if(clean == 2)
+ clean = 'git clean -xdff'
Review comment:
Please leave this as it is.
The workspace always has to be considered empty and reproducible. If you
need to persist something in between stages, use the stashing mechanism. With
this change you are circumventing a problem - that you are not persisting state
properly - and it will blow up as soon as we have more than one restricted
slave and job one gets scheduled onto a different slave than job two
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
