TaoLv commented on a change in pull request #12980: Add reshape op supported by MKL-DNN URL: https://github.com/apache/incubator-mxnet/pull/12980#discussion_r238972572
########## File path: src/operator/tensor/matrix_op.cc ########## @@ -210,24 +272,18 @@ static void FlattenEx(const nnvm::NodeAttrs& attrs, #endif } +#if MXNET_USE_MKLDNN == 1 Review comment: Seems this will change the original behavior when MKL-DNN is not enabled. `FlattenStorageType` is not defined then. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
