larroy commented on issue #13438: libc getenv is not threadsafe URL: https://github.com/apache/incubator-mxnet/issues/13438#issuecomment-444590239 process != thread. In this case I think you mean thread. Other than that I agree with your analysis. I think we need to understand if not using this variable as in https://github.com/apache/incubator-mxnet/pull/13472 makes unwanted threads to be spawn inside the engine workers, because it might actually not be the case. Depending on that, we need to see if we need to use a different mechanism in the engine to control OMP threads, then run performance regression tests. As you see from my PR, not changing the environment is functionally correct, but I don't know if it has performance impact because of the reason explained above.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
