larroy edited a comment on issue #13528: Scala jar contains the scala standard library URL: https://github.com/apache/incubator-mxnet/issues/13528#issuecomment-444626117 While I think is ok to provide a fat jar for people trying MXNet in the console as you point out, we should provide a standard version with just MXNet and the binary dynamic libraries inside, without standard scala library or other dependencies that can be pulled from maven. Some of the comments I got from other engineers when I explained this issue were: > Definitely not. Maven artifacts should not be fat jars. The jar should only include classes and resources that are part of the enclosing project. > maven has a concept of "assembly" builds and repo can have those types of artifacts published, but that obvioulsy should be clearly documented or has designated classifier to warn consumers > In any case the build should not replace the default artifact with the output of an assembly build that pulls all dependencies, especially if this jar is then published to a Maven repository and can be imported by other Maven projects. I don't want to irritate anyone with this issue because you guys have done great work putting the Scala package forward. But my feedback about this topic stands as it is if there's no new information provided. I asked other senior engineers in Amazon about this issue and their feedback was the same as mine. They also have extensive experience running big java / Scala projects. I have maintained Spark myself inside amazon for a few releases (it's a huge project) and worked in big Scala projects for Amazon which are now in production (SageMaker) and other companies like Nokia, so I think I know one thing or two about Scala and dependencies. I suggest you guys do your due diligence about this topic and find out what's the best practice if my arguments are not convincing. If you need people to contact to gather more opinions I can suggest the Scala lists inside Amazon, external sources like stackoverflow or I can provide some names. If you need more help or feedback from my side, let me know. Happy to help.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
