ZhennanQin commented on a change in pull request #12980: Add reshape op supported by MKL-DNN URL: https://github.com/apache/incubator-mxnet/pull/12980#discussion_r239306007
########## File path: src/operator/tensor/matrix_op.cc ########## @@ -210,24 +272,18 @@ static void FlattenEx(const nnvm::NodeAttrs& attrs, #endif } +#if MXNET_USE_MKLDNN == 1 Review comment: This is followed new style with other mkldnn op, that is, defining InferStorageType function within MKLDNN macro. Most other ops are refactored into this style by Luobao, I guess this one is missing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
