zheng-da commented on a change in pull request #13509: Speedup and fix bug for dgl_csr_sampling op URL: https://github.com/apache/incubator-mxnet/pull/13509#discussion_r239363346
########## File path: src/operator/contrib/dgl_graph.cc ########## @@ -464,79 +449,87 @@ static void NegateSet(const std::vector<size_t> &idxs, /* * Uniform sample */ -static void GetUniformSample(const std::vector<dgl_id_t>& ver_list, - const std::vector<dgl_id_t>& edge_list, +static void GetUniformSample(const dgl_id_t* val_list, + const dgl_id_t* col_list, + const dgl_id_t* indptr, + const dgl_id_t dst_id, Review comment: I think you can pass val_list + offset, col_list + offset, and size. it'll make the arguments easier to understand and the implementation a littel simpler. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
