marcoabreu commented on issue #13362: Add NHWC layout support to Pooling (cuDNN 
only)
URL: https://github.com/apache/incubator-mxnet/pull/13362#issuecomment-444815558
 
 
   Great catch! Do you mind adding a test that runs on both cpu and gpu?
   
   I'm still having trouble to understand why we are exposing the Backend 
(whether it's cudnn or mkldnn) to the frontend and making conditional tests. 
The tests should work with any Backend (except if there is no valid 
implementation available). In an ideal world, we would just call the Operator 
and the mkldnn/cudnn magic would be done by the Backend. I think this new 
structure is a good step towards that.
   
   Can we already add a generalized test that both works on CPU and GPU at this 
stage to catch Taos error?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to