aaronmarkham commented on a change in pull request #13519: Fix exception 
handling api doc
URL: https://github.com/apache/incubator-mxnet/pull/13519#discussion_r239678408
 
 

 ##########
 File path: python/mxnet/ndarray/ndarray.py
 ##########
 @@ -157,6 +157,11 @@ def waitall():
     """Wait for all async operations to finish in MXNet.
 
     This function is used for benchmarking only.
+    Rethrowing exceptions as part of mx.nd.waitall is not supported.
 
 Review comment:
   ```suggestion
   . warning:: 
       If your code has exceptions, `waitall` can cause silent failures.
       For this reason you should avoid `waitall` in your code. 
       Use it only if you are confident that your code is error free. 
       Then make sure you call `wait_to_read` on all outputs after `waitall`.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to