larroy commented on a change in pull request #13573: Add timeout/retry logic to
docker cache download
URL: https://github.com/apache/incubator-mxnet/pull/13573#discussion_r239777087
##########
File path: ci/docker_cache.py
##########
@@ -131,14 +134,15 @@ def _login_dockerhub():
logging.error(p.stderr)
# Linear backoff
- time.sleep(1000 * DOCKERHUB_RETRY_SECONDS * (i + 1))
+ time.sleep(DOCKERHUB_RETRY_SECONDS * (i + 1))
Review comment:
can we use @retry decorator, it's in util under CI I think. just so we
don't reimplement retry logic everytime. Or maybe you can abstract this in
another retry_with_timeout deco.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
