larroy commented on a change in pull request #13339: CMake: Enable installation
of cpp-package headers
URL: https://github.com/apache/incubator-mxnet/pull/13339#discussion_r239785656
##########
File path: CMakeLists.txt
##########
@@ -730,6 +730,7 @@ install(TARGETS ${MXNET_INSTALL_TARGETS}
)
install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+install(DIRECTORY 3rdparty/tvm/nnvm/include/ DESTINATION
${CMAKE_INSTALL_INCLUDEDIR})
Review comment:
Could you please add comments to where are we installing things by default?
it's quite hidden in CMAKE documentation where they go. ( I had to dig a bit )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
