Roshrini commented on a change in pull request #12399: ONNX export: Add Crop, 
Deconvolution and fix the default stride of Pooling to 1
URL: https://github.com/apache/incubator-mxnet/pull/12399#discussion_r239904398
 
 

 ##########
 File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
 ##########
 @@ -571,7 +637,7 @@ def convert_pooling(node, **kwargs):
 
     kernel = eval(attrs["kernel"])
     pool_type = attrs["pool_type"]
 
 Review comment:
   Can you also add default value for pool_type?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to